ZAOstock Round 5: PR #319 - Sunlight Contrast Mode & Outdoor Mobile Legibility
https://github.com/ZAODEVZ/ZAOstock/pull/319Notes: You went at the top of the list rather than the easy end of it, and you built for a specific person.
Somebody on Franklin Street at midday in October trying to find out when a band plays. You also went and found our own line in DESIGN.md about staying legible at 14px on a phone in sunlight and built to it, rather than guessing at what was meant. That is reading the brief instead of reading the title. All four jobs pass.
The sunlight CSS does not currently apply, and there is already a review on the PR saying so. This is not being delivered twice: a Changes requested review went up on #319 on 27 September with the detail. The short version is that a selector list cannot contain an @media prelude, so the whole block is invalid and the browser keeps zero rules from it. It was run through the repo's own CSS pipeline against a control rather than asserted from the spec.
The part worth taking from it is the test, not the fix. Your test asserts that the CSS source text contains '@media (prefers-contrast: more)'. It reads the source as a string, so it passes because the broken text is present - the test passes BECAUSE of the defect it should have caught. A test that could catch this has to assert a computed style: render it, toggle the class, read getComputedStyle. Playwright is already wired here and there is exactly one e2e spec for forty pages, so there is room.
The question. You fixed contrast by moving colours. Did you check the result against a measurement, or by eye? Another entrant in this round ran axe over the home page and counted failures before and after. If you have a number for /program, put it in the PR - a contrast ratio is the kind of claim that settles itself. And if you want more of this: accessibility across the rest of the site is wide open, and almost nobody does it.